Skip to content

Make set creadential label use reset-password scope #43714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroigor merged 1 commit into from
Nov 3, 2025
+8 −2
Merged

Make set creadential label use reset-password scope #43714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/src/main/java/org/keycloak/services/resources/admin/UserResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ public void removeCredential(final @PathParam("credentialId") String credentialI
@APIResponse(responseCode = "404", description = "Not Found")
})
public void setCredentialUserLabel(final @PathParam("credentialId") String credentialId, String userLabel) {
auth.users().requireManage(user);
auth.users().requireResetPassword(user);
CredentialModel credential = user.credentialManager().getStoredCredentialById(credentialId);
if (credential == null) {
// we do this to make sure somebody can't phish ids
Expand Down Expand Up @@ -1324,4 +1324,4 @@ public SendEmailParams(String redirectUri, String clientId, Integer lifespan) {
this.lifespan = lifespan;
}
}
}
}
6 changes: 6 additions & 0 deletions ...ase/src/test/java/org/keycloak/tests/admin/authz/fgap/UserResourceTypeEvaluationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.keycloak.tests.admin.authz.fgap;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.instanceOf;
import static org.hamcrest.Matchers.notNullValue;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -474,6 +475,11 @@ public void testResetPassword() {
createPermission(client, userAlice.admin().toRepresentation().getId(), usersType, Set.of(VIEW), allowMyAdminPermission);

users.get(search.get(0).getId()).resetPassword(credential);

// set credential label - admin UI sets the label upon resetting the password
List<CredentialRepresentation> credentials = users.get(search.get(0).getId()).credentials();
assertThat(credentials, hasSize(1));
users.get(search.get(0).getId()).setCredentialUserLabel(credentials.get(0).getId(), "User Label");
}

@Test
Expand Down
Loading