Skip to content

fix: allow for --optimized to receive signals #43580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmuzikar merged 2 commits into from
Oct 20, 2025
+25 −2
Merged

fix: allow for --optimized to receive signals #43580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f8e754
fix: allowing --optimized to terminate gracefully
shawkins Oct 18, 2025
672f2a0
Update quarkus/dist/src/main/content/bin/kc.sh
shawkins Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions quarkus/dist/src/main/content/bin/kc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,14 @@ if [ "$PRINT_ENV" = "true" ]; then
echo "Using JAVA_RUN_OPTS: $JAVA_RUN_OPTS"
fi

eval "'$JAVA'" "$JAVA_RUN_OPTS"
status=$?
# trap the signals that should be forwarded to the java process
trap 'status=143; while [ -z "$PID" ]; do sleep 0.1; done; kill -TERM $PID; wait $PID' TERM INT
# run the java process in the background using the current stdin
eval "{ '$JAVA' $JAVA_RUN_OPTS <&3 3<&- & } 3<&0"
# obtain the pid, and await the exit status
PID=$!; wait $PID; status=$?
# remove the trap as signals can be directly handled
trap - TERM INT
# only exit code 10 means that implicit reaugmentation occurred and a relaunch is needed
if [ $status = 10 ]; then
JAVA_RUN_OPTS="-Dkc.config.built=true $JAVA_RUN_OPTS"
Expand Down
17 changes: 17 additions & 0 deletions quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/StartCommandDistTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,23 @@ void noErrorSpiBuildtimeNotChanged(KeycloakDistribution dist) {
cliResult.assertNoError("The following build time options");
}

@Test
@RawDistOnly(reason = "Containers are immutable")
void terminateStartOptimized(KeycloakDistribution dist) {
CLIResult cliResult = dist.run("build", "--db=dev-file");
cliResult.assertBuild();

dist.setManualStop(true);
cliResult = dist.run("start", "--optimized", "--http-enabled=true", "--hostname-strict=false");
cliResult.assertStarted();

// if the child java process does not clean up, then subsequent start will fail
dist.stop();

cliResult = dist.run("start", "--optimized", "--http-enabled=true", "--hostname-strict=false");
cliResult.assertStarted();
}

@DryRun
@Test
@Launch({ "--profile=dev", "start", "--db=dev-file" })
Expand Down
Loading