-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix: noting db support level changes #43549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andymunro - please include this changes in the downstream docs for 26.4.x. Thanks! |
|
|
||
| [cols="1,1,1"] | ||
| |=== | ||
| |Database |Minimum support |Dialect minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to state dialect minimum? It's not consistent with the guide where we don't state it. It might also be confusing to the users what is "dialect minimum". But I understand the motivation – before, we didn't state the supported versions in the upstream, and users are now surprised by the dialect limitations. So probably ok to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes: keycloak#43191 Signed-off-by: Steve Hawkins <[email protected]>
vmuzikar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
closes: keycloak#43191 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 736d492)
closes: #43191 (cherry picked from commit 736d492) Signed-off-by: Steve Hawkins <[email protected]>
closes: #43191