fix: refining https-protocols documentation #43420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vmuzikar @ahus1 @statist32 the failure makes it look like spotless is running against the entire code base, not just the files touched in the pr. Is this expected? |
closes: keycloak#43164 Signed-off-by: Steve Hawkins <[email protected]>
ahus1
approved these changes
Oct 14, 2025
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for this change. Not merging yet as there are still other reviewers. Ping me if you want this to be merged.
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 14, 2025
closes: keycloak#43164 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 700b86f) Steven Hawkins <[email protected]>
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 14, 2025
closes: keycloak#43164 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 700b86f)
vmuzikar
pushed a commit
that referenced
this pull request
Oct 14, 2025
closes: #43164 (cherry picked from commit 700b86f) Signed-off-by: Steve Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #43164
Changed the example to mirror the current quarkus docs, rather than implying that TLSv1.2 is not enabled by default. Also made the option documentation clearer wrt expected values - we may want to log an issue against quarkus to more strongly validate, or we can do this as a breaking change with #43332