Avoid invalidating the realm when managing client initial access #42923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#42922 Signed-off-by: Alexander Schwartz <[email protected]>
Contributor
Author
|
@pruivo - do you feel confident enough to review this PR, assuming that you haven't worked with client invalidation before? |
pruivo
approved these changes
Sep 24, 2025
Member
pruivo
left a comment
There was a problem hiding this comment.
LGTM. If I didn't miss anything, it does not interact with any cached data.
Whether those methods belong to RealModel is another story :) They exist in RealmProvider, and all invocations appear to be directed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42922
This can be manually validated in one of the two following ways - I actually don't know how I would automatically test this, please share ideas if you could think of some.
OR
You then look that no Realm invalidations are created in the debugger at
keycloak/model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/events/RealmUpdatedEvent.java
Line 39 in 18a6c79