-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Clarifying OIDC logout documentation. Removing obsolete unused docs p… #42636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages closes keycloak#41792 Signed-off-by: mposolda <[email protected]>
Contributor
Author
|
@andymunro Do you please have a chance to review this PR? |
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/clients/oidc/con-basic-settings.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: andymunro <[email protected]> Signed-off-by: Marek Posolda <[email protected]>
Contributor
Author
|
@andymunro Suggestions applied. Thanks for the review! |
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
Contributor
|
You are welcome. I am still looking for where else I can provide input. |
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
reviewed
Sep 16, 2025
docs/documentation/server_admin/topics/sso-protocols/con-oidc-auth-flows.adoc
Outdated
Show resolved
Hide resolved
andymunro
suggested changes
Sep 16, 2025
Contributor
andymunro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @mposolda with a few changes to suggest.
Co-authored-by: andymunro <[email protected]> Signed-off-by: Marek Posolda <[email protected]>
Contributor
Author
|
@andymunro Thanks! |
andymunro
approved these changes
Sep 16, 2025
Awambeng
added a commit
to adorsys/keycloak-oid4vc
that referenced
this pull request
Sep 19, 2025
* fix proposal for issue 41804 Signed-off-by: pematth <[email protected]> * removed unused include Signed-off-by: pematth <[email protected]> * fixed getter setter for expiresIn comparable to refreshExpiresIn * added junit tests for refreshExpiresIn fix * added null check also for optional expires_in parameter * Make sure refresh expiration is set together with setting the previous refresh token Signed-off-by: Pedro Igor <[email protected]> * fix: cleaning up dockerfile build warnings (keycloak#42573) closes: keycloak#42572 Signed-off-by: Steve Hawkins <[email protected]> * fix: updating export option text (keycloak#42621) closes: keycloak#42011 Signed-off-by: Steve Hawkins <[email protected]> * Fix chinese language names Closes keycloak#42575 Signed-off-by: Alexander Schwartz <[email protected]> * Concurrent update embedded caches and database Closes keycloak#42374 Signed-off-by: Pedro Ruivo <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Co-authored-by: Pedro Ruivo <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]> * Keycloak 26.4 Upgrading Guide Closes keycloak#42564 Signed-off-by: AndyMunro <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]> * redirectToAuthentication if the request uses PAR to not lose the single object after a refresh Closes keycloak#36716 Signed-off-by: rmartinc <[email protected]> * [OID4VCI] Adjust Credential Issuer Metadata endpoint, return issuer metadata at /.well-known/openid-credential-issuer/realms/{realm} (keycloak#42577) Closes keycloak#41589 Signed-off-by: Awambeng <[email protected]> * Create default ServiceMonitor with Operator Closes keycloak#40406 Signed-off-by: Ryan Emerson <[email protected]> * Validate wait_timeout parameter on MySQL and MariaDB Closes keycloak#42300 Signed-off-by: Ryan Emerson <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]> * Update Slovenian translations for login messages (keycloak#42637) Signed-off-by: MartinFMartin <[email protected]> * Automatic download and cache of the SAML client public keys (keycloak#41947) Closes keycloak#17028 Signed-off-by: rmartinc <[email protected]> * Rename RLM to Workflows Closes keycloak#42512 Signed-off-by: vramik <[email protected]> * fix: aligning the elytron alt name extraction logic (keycloak#41975) closes: keycloak#40629 Signed-off-by: Steve Hawkins <[email protected]> * fix: adding docs about mTLS and probes (keycloak#42561) closes: keycloak#42191 Signed-off-by: Steve Hawkins <[email protected]> * Client Authenticator configurable per client Closes keycloak#42044 Signed-off-by: Giuseppe Graziano <[email protected]> * fix: updating docs related to the number of executor threads closes: keycloak#39342 Signed-off-by: Steve Hawkins <[email protected]> * Clarifying OIDC logout documentation. Removing obsolete unused docs p… (keycloak#42636) closes keycloak#41792 Signed-off-by: mposolda <[email protected]> Signed-off-by: Marek Posolda <[email protected]> Co-authored-by: andymunro <[email protected]> * NullPointerException when persisting a client session Fixes keycloak#42652 Signed-off-by: Pedro Ruivo <[email protected]> Co-authored-by: Pedro Ruivo <[email protected]> * Document Operator ServiceMonitor generation in release notes Closes keycloak#42642 Signed-off-by: Ryan Emerson <[email protected]> * Stabilizing test by waiting for the response Closes keycloak#42650 Signed-off-by: Alexander Schwartz <[email protected]> * [Keycloak Test Framework] Infinispan cache + ClusterlessTestSuite configuration (keycloak#42172) * [Keycloak Test Framework] Infinispan server + ClusterlessTestSuite and MultisiteTestSuite configuration Signed-off-by: Lukas Hanusovsky <[email protected]> * Utilise ClientIntelligence.BASIC to ensure that internal docker IPs never used by Infinispan client Signed-off-by: Ryan Emerson <[email protected]> * Code refactoring + properties utility Signed-off-by: Lukas Hanusovsky <[email protected]> --------- Signed-off-by: Lukas Hanusovsky <[email protected]> Signed-off-by: Ryan Emerson <[email protected]> Co-authored-by: Ryan Emerson <[email protected]> * chore(oid4vc): Remove format parameter from CredentialRequest Closes keycloak#42677 Signed-off-by: Awambeng Rodrick <[email protected]> --------- Signed-off-by: pematth <[email protected]> Signed-off-by: Pedro Igor <[email protected]> Signed-off-by: Steve Hawkins <[email protected]> Signed-off-by: Alexander Schwartz <[email protected]> Signed-off-by: Pedro Ruivo <[email protected]> Signed-off-by: AndyMunro <[email protected]> Signed-off-by: rmartinc <[email protected]> Signed-off-by: Awambeng <[email protected]> Signed-off-by: Ryan Emerson <[email protected]> Signed-off-by: MartinFMartin <[email protected]> Signed-off-by: vramik <[email protected]> Signed-off-by: Giuseppe Graziano <[email protected]> Signed-off-by: mposolda <[email protected]> Signed-off-by: Marek Posolda <[email protected]> Signed-off-by: Lukas Hanusovsky <[email protected]> Signed-off-by: Awambeng Rodrick <[email protected]> Co-authored-by: pematth <[email protected]> Co-authored-by: Matthias Peter <[email protected]> Co-authored-by: Pedro Igor <[email protected]> Co-authored-by: Steven Hawkins <[email protected]> Co-authored-by: Alexander Schwartz <[email protected]> Co-authored-by: Pedro Ruivo <[email protected]> Co-authored-by: Pedro Ruivo <[email protected]> Co-authored-by: andymunro <[email protected]> Co-authored-by: rmartinc <[email protected]> Co-authored-by: Ryan Emerson <[email protected]> Co-authored-by: MartinFMartin <[email protected]> Co-authored-by: vramik <[email protected]> Co-authored-by: Giuseppe Graziano <[email protected]> Co-authored-by: Marek Posolda <[email protected]> Co-authored-by: Lukas Hanusovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ages
closes #41792
Clarifying some points around OIDC logout in the Keycloak documentation in general.