-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[admin-api-v2] Provide simple validation with Jakarta/Hibernate Validation #41110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin-api-v2] Provide simple validation with Jakarta/Hibernate Validation #41110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNodeKeycloak CI - Store Model Tests |
9007ef0 to
5c25c25
Compare
562be58 to
aadbf3f
Compare
…ation Signed-off-by: Martin Bartoš <[email protected]>
5c25c25 to
34ac303
Compare
vmuzikar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good start and we can even merge as is. It'd be good though to have a follow-up to showcase some custom logic validation.
266bb90
into
keycloak:feature/admin-api-v2
|
@vmuzikar Thanks, yep I'd say it's a good start for this. However, for the automatic validation based on the annotations, we'd need to do some more things which would not be so easy to do and would require possibly some discussion. Possible approaches:
I'm inclined more to (2) as it's a recommended way in applications and on Quarkus side and it could simplify a lot of things for us. I'll try to do some prototype on this matter. |
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]>
…ation (#41110) Signed-off-by: Martin Bartoš <[email protected]>
…ation (#41110) Signed-off-by: Martin Bartoš <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
…ation (keycloak#41110) Signed-off-by: Martin Bartoš <[email protected]> Signed-off-by: Václav Muzikář <[email protected]>
WIP