Move ConsentsTest.java to the new testsuite #40323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
waiting for the UserTest PR being merged, there are Page dependencies: #39805 |
f9c9b5f to
f627489
Compare
vaceksimon
reviewed
Jul 18, 2025
Comment on lines
412
to
419
| private boolean isRefreshToken(String refreshToken) { | ||
| String[] items = refreshToken.split(":"); | ||
| if (items.length != 2) return false; | ||
| // Grant type shortcut starts at character 4th char and is 2-chars long | ||
| if (!items[0].substring(3, 5).equals(RefreshTokenGrantTypeFactory.GRANT_SHORTCUT)) return false; | ||
|
|
||
| return isRefreshToken(items[1]); | ||
| } |
Contributor
There was a problem hiding this comment.
This method appears to be unused
Comment on lines
83
to
111
| @InjectRealm(ref = "user") | ||
| ManagedRealm managedRealm; | ||
|
|
||
| protected String consumerRealmName() { | ||
| return REALM_CONS_NAME; | ||
| } | ||
| @InjectRealm(ref = "consumer", config = ConsentsRealmCConf.class, lifecycle = LifeCycle.METHOD) | ||
| ManagedRealm consumerRealm; | ||
|
|
||
| protected String getIDPAlias() { | ||
| return IDP_OIDC_ALIAS; | ||
| } | ||
| @InjectRealm(ref = "provider", lifecycle = LifeCycle.METHOD) | ||
| ManagedRealm providerRealm; | ||
|
|
||
| @Rule | ||
| public AssertEvents events = new AssertEvents(this); | ||
| @InjectUser(ref = "user", realmRef = "user", config = ConsentsUserConf.class) | ||
| ManagedUser user; | ||
|
|
||
| @Page | ||
| protected LoginPage accountLoginPage; | ||
| @InjectUser(ref = "provider", realmRef = "provider", config = ConsentsUserPConf.class) | ||
| ManagedUser userP; | ||
|
|
||
| @Page | ||
| protected ConsentPage consentPage; | ||
| @InjectClient(realmRef = "provider", config = ConsentsClientPConf.class) | ||
| ManagedClient client; | ||
|
|
||
| @Page | ||
| protected AppPage appPage; | ||
| @InjectOAuthClient(ref = "user", realmRef = "user") | ||
| OAuthClient oauth; | ||
|
|
||
| @Page | ||
| protected ErrorPage errorPage; | ||
| @InjectOAuthClient(ref = "consumer", realmRef = "consumer") | ||
| OAuthClient oauthC; | ||
|
|
||
| @Override | ||
| public void addTestRealms(List<RealmRepresentation> testRealms) { | ||
| RealmRepresentation providerRealm = createProviderRealm(); | ||
| RealmRepresentation consumerRealm = createConsumerRealm(); | ||
| RealmRepresentation realmRepresentation = loadJson(getClass().getResourceAsStream("/testrealm.json"), RealmRepresentation.class); | ||
| @InjectOAuthClient(ref = "provider", realmRef = "provider") | ||
| OAuthClient oauthP; | ||
|
|
||
| testRealms.add(providerRealm); | ||
| testRealms.add(consumerRealm); | ||
| testRealms.add(realmRepresentation); | ||
| } | ||
| @InjectEvents(realmRef = "user") | ||
| Events events; |
Contributor
There was a problem hiding this comment.
The naming in this area is confusing. There's a managedRealm with a ref="user", in that realm, there's a user. There's also a userP which is in providerRealm.
I would unify the names and be a bit more descriptive than oauthC
Signed-off-by: Lukas Hanusovsky <[email protected]>
Part of: keycloak#34494 Signed-off-by: Lukas Hanusovsky <[email protected]>
vaceksimon
approved these changes
Jul 22, 2025
stianst
approved these changes
Jul 22, 2025
robson90
pushed a commit
to robson90/keycloak
that referenced
this pull request
Jul 23, 2025
* Moving files to the new test suite Signed-off-by: Lukas Hanusovsky <[email protected]> * Move ConsentsTest.java, UserRoleTest.java to the new testsuite Part of: keycloak#34494 Signed-off-by: Lukas Hanusovsky <[email protected]> --------- Signed-off-by: Lukas Hanusovsky <[email protected]> Signed-off-by: Robin Meese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #34494