Fix NPE during external-internal token exchange in case that user exists #40105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroigor
previously approved these changes
May 30, 2025
Contributor
|
LGTM. But I'm wondering if we really want to update the email when doing token exchanges? Perhaps it makes more sense to skip it ... |
Contributor
Author
That works for me. Updated the PR. Used separate commit, but I can squash during the merge. What do you think? |
pedroigor
approved these changes
May 30, 2025
Contributor
pedroigor
left a comment
There was a problem hiding this comment.
Thanks. I think this was the behavior before my last change to email/verification in brokering.
closes keycloak#40104 Signed-off-by: mposolda <[email protected]>
fa10d4c to
a428ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40104