Skip to content

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Dec 5, 2024

Introduces the ability for an extension to auto-register some value types.

This solves the issue with the remote extension that currently results in restarting the server between tests that use TimeOffSet and those that don't.

Closes #35592

Signed-off-by: stianst [email protected]

@stianst stianst requested a review from a team as a code owner December 5, 2024 08:58
public class Registry implements ExtensionContext.Store.CloseableResource {

private RegistryLogger logger;
private static final Logger log = LoggerFactory.getLogger(Registry.class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst this seems to be redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, removing


public abstract class AbstractInterceptorHelper<I, V> {

private static final Logger LOGGER = Logger.getLogger(AbstractInterceptorHelper.class);
Copy link
Contributor

@lhanusov lhanusov Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst don't you want to use RegistryLogger instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating

Copy link
Contributor

@lhanusov lhanusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stianst stianst force-pushed the tests-refactor-registry branch 2 times, most recently from 8546f00 to f63165c Compare December 5, 2024 10:48
@stianst stianst force-pushed the tests-refactor-registry branch from f63165c to fb10526 Compare December 5, 2024 10:56
@stianst stianst merged commit 9ab5575 into keycloak:main Dec 5, 2024
73 checks passed
@stianst stianst deleted the tests-refactor-registry branch December 5, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve supplier interceptor for dependencies

2 participants