-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Introduce support for an extension to auto register a value type #35645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public class Registry implements ExtensionContext.Store.CloseableResource { | ||
|
|
||
| private RegistryLogger logger; | ||
| private static final Logger log = LoggerFactory.getLogger(Registry.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stianst this seems to be redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, removing
|
|
||
| public abstract class AbstractInterceptorHelper<I, V> { | ||
|
|
||
| private static final Logger LOGGER = Logger.getLogger(AbstractInterceptorHelper.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stianst don't you want to use RegistryLogger instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating
lhanusov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8546f00 to
f63165c
Compare
Closes keycloak#35592 Signed-off-by: stianst <[email protected]>
f63165c to
fb10526
Compare
Introduces the ability for an extension to auto-register some value types.
This solves the issue with the
remoteextension that currently results in restarting the server between tests that useTimeOffSetand those that don't.Closes #35592
Signed-off-by: stianst [email protected]