fix: changing the bootstrapping suggestion to the command #35616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: keycloak#35526 Signed-off-by: Steve Hawkins <[email protected]>
jonkoops
reviewed
Dec 4, 2024
| } | ||
| } | ||
|
|
||
| protected String getAdminCreationMessage() { |
Contributor
There was a problem hiding this comment.
Does this actually get used anywhere? Perhaps we can get rid of this code. Or let's at least log an issue to clean this up in v27.
Contributor
There was a problem hiding this comment.
The adminUserCreationMessage property doesn't seem to be used, you're right. I don't think we need to wait to 27 before removing it. But we can do it as a follow-up.
Contributor
There was a problem hiding this comment.
Actually, we can't remove as custom themes might be using it. So we need to wait to 27...
Contributor
Author
There was a problem hiding this comment.
Should I capture this as a follow up issue then?
Contributor
There was a problem hiding this comment.
Ok, then let's log a task to remove it in the next major
vmuzikar
approved these changes
Dec 5, 2024
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Dec 5, 2024
…5616) closes: keycloak#35526 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 4c7dea5)
shawkins
added a commit
that referenced
this pull request
Dec 6, 2024
…35666) closes: #35526 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 4c7dea5)
Closed
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Dec 11, 2024
…5616) (keycloak#35666) closes: keycloak#35526 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 4c7dea5) Signed-off-by: Erik Jan de Wit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #35526
cc @jonkoops @vmuzikar the admin message from the welcome resource doesn't seem to be used by us, but I'm not sure if it could be used by something custom and therefore needs to stay for now.