Skip to content

Conversation

@agagancarczyk
Copy link
Contributor

Closes #35475

Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastEnn
Copy link
Contributor

FYI https://www.i18next.com/translation-function/plurals

So we would need

deleteConfirmUser_one=Delete user?
deleteConfirmUser_other=Delete users?

in messages_en.properties.

This would break compatibility with other translations tho 🤔

@jonkoops
Copy link
Contributor

jonkoops commented Dec 3, 2024

This would break compatibility with other translations tho

Would it? This just means they need to be updated.

@SebastEnn
Copy link
Contributor

Would it? This just means they need to be updated.

Well, the key is deleteConfirmUsers and the value Delete user?.
Some languages might have set the value to something that would fit _other, and some other maybe for _one.

Either way, translations would need to be updated. So I guess we can ignore this and eventually someone will notice and fix the translation 🙂

@edewit
Copy link
Contributor

edewit commented Dec 4, 2024

@SebastEnn we add and update the translations constantly and we only maintain the English version, so broken translations can't be helped

Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
@agagancarczyk agagancarczyk merged commit 2e85dc5 into keycloak:main Dec 4, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete user confirm title is wrong

4 participants