Skip to content

Keycloak-admin-client should work with the future versions of Keycloak server (#34285) #34293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
Oct 24, 2024
Merged

Keycloak-admin-client should work with the future versions of Keycloak server (#34285) #34293

mposolda merged 1 commit into from
Oct 24, 2024

Conversation

@mposolda
Copy link
Contributor

@mposolda mposolda commented Oct 24, 2024

closes #34284

Signed-off-by: mposolda [email protected]
(cherry picked from commit 2e4a3f6)

@mposolda mposolda requested a review from a team as a code owner October 24, 2024 10:45
@mposolda mposolda self-assigned this Oct 24, 2024
@mposolda mposolda requested a review from jonkoops October 24, 2024 10:46
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 24, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 24, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@mposolda mposolda merged commit 0361d75 into keycloak:release/26.0 Oct 24, 2024
@mposolda mposolda mentioned this pull request Oct 24, 2024
Merged
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mposolda @jonkoops