Skip to content

Fix password validation with uppercase and lowercase minimum requirements (#34152) #34240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonkoops merged 1 commit into from
Oct 23, 2024
Merged

Fix password validation with uppercase and lowercase minimum requirements (#34152) #34240

jonkoops merged 1 commit into from
Oct 23, 2024

Conversation

@jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Oct 23, 2024

Closes #34151

Signed-off-by: SebastEnn [email protected]
(cherry picked from commit e6e2bfd)

@jonkoops jonkoops requested review from a team as code owners October 23, 2024 10:10
@jonkoops jonkoops mentioned this pull request Oct 23, 2024
Merged
@jonkoops jonkoops enabled auto-merge (squash) October 23, 2024 10:11
@rmartinc rmartinc mentioned this pull request Oct 23, 2024
Merged
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 23, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 23, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test

@jonkoops jonkoops merged commit 164a6b1 into keycloak:release/26.0 Oct 23, 2024
@jonkoops jonkoops deleted the backport-34152-26.0 branch October 23, 2024 11:55
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkoops @ssilvert @SebastEnn