fix: providing a separate session for each file #34210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: keycloak#34095 Signed-off-by: Steve Hawkins <[email protected]>
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 23, 2024
closes: keycloak#34095 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit bd49975)
Contributor
Author
Absolutely. I would have liked to do that, but it's quite a change. As far as I can see the lifecycle of the provider factory and provider aren't designed well for this. An option would be to put config overrides on the KeycloakContext (and reference that in the provider, rather than System.getxxx) - when those are present, we'd also have to use them as part of the cache keys with further changes along the lines of #34220
|
vmuzikar
pushed a commit
that referenced
this pull request
Oct 23, 2024
closes: #34095 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit bd49975)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34095
An alternative here was to expand the KeycloakSession logic so that it can return a new, not cached, provider instance. However I thought that this usage of system properties should be a special case and decided against it.