fix: corrects cli arg stringification #34156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: keycloak#34155 Signed-off-by: Steve Hawkins <[email protected]>
vmuzikar
approved these changes
Oct 23, 2024
|
|
||
| public static final String NAME = "show-config"; | ||
| private static final List<String> ignoredPropertyKeys = List.of( | ||
| "kc.config.args", "kc.show.config", "kc.profile", "kc.quarkus-properties-enabled", "kc.home.dir"); |
Contributor
There was a problem hiding this comment.
Just out of curiosity. We're still setting the kc.config.args sys prop as before. Why we don't need to ignore it any longer? It might still be recognized as a config option, no?
Contributor
Author
There was a problem hiding this comment.
We must have at some point seen system properties as config properties. This and the check for build time properties seem to indicate that - however system properties are no longer picked up as config properties, so we don't need this.
Contributor
There was a problem hiding this comment.
Ok, right. Let's get this merged.
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 23, 2024
closes: keycloak#34155 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 358d234)
vmuzikar
pushed a commit
that referenced
this pull request
Oct 23, 2024
closes: #34155 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit 358d234)
2 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34155
I would have liked to just use a new static variable on ConfigArgsConfigSource, but that doesn't seem to work because a different classload is used for building.