enable autocomplete for Username Form #34099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you forgot to sign off the commit [1], as shown here [2]. To fix this, run: git clone --single-branch --branch feature_autocomplete [email protected]:xsrf/keycloak.git
git commit --amend --signoff -m "Enable autocomplete for Username Form" -m "This allows browsers and password managers to suggest a username." -m "Closes https://github.com/keycloak/keycloak/issues/34091"
git push -fAlso, I recommend updating your PR description to match the commit message, for the reasons mentioned here [3]. [1] https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#developers-certificate-of-origin |
jonkoops
approved these changes
Oct 18, 2024
This allows browsers and password managers to suggest a username. Closes keycloak#34091 Signed-off-by: xsrf <[email protected]>
95b82f7 to
668940f
Compare
codespearhead
approved these changes
Oct 18, 2024
jonkoops
pushed a commit
to jonkoops/keycloak
that referenced
this pull request
Dec 3, 2024
Closes keycloak#34091 Signed-off-by: xsrf <[email protected]> (cherry picked from commit 47a7d9c)
jonkoops
added a commit
that referenced
this pull request
Dec 3, 2024
Closes #34091 Signed-off-by: xsrf <[email protected]> (cherry picked from commit 47a7d9c) Co-authored-by: Andreas <[email protected]>
Closed
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Dec 11, 2024
…35543) Closes keycloak#34091 Signed-off-by: xsrf <[email protected]> (cherry picked from commit 47a7d9c) Co-authored-by: Andreas <[email protected]> Signed-off-by: Erik Jan de Wit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable autocomplete for Username Form
This allows browsers and password managers to suggest a username.
Closes #34091