Clear all entries stored in local storage #34056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f286ea to
fcb26ef
Compare
douglaspalmer
suggested changes
Oct 17, 2024
Contributor
douglaspalmer
left a comment
There was a problem hiding this comment.
The changes look good. One small suggestion if checkValidity() is going to return true for invalid entries can it be refactored to isInvalid(). In my mind checkValidity would return true if the entry was valid.
Closes keycloak#15635 Signed-off-by: Jon Koops <[email protected]>
fcb26ef to
1280769
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
agagancarczyk
approved these changes
Oct 17, 2024
jonkoops
added a commit
to jonkoops/keycloak
that referenced
this pull request
Oct 18, 2024
Closes keycloak#15635 Signed-off-by: Jon Koops <[email protected]> (cherry picked from commit 31ce14a)
jonkoops
added a commit
that referenced
this pull request
Oct 18, 2024
Closes #15635 Signed-off-by: Jon Koops <[email protected]> (cherry picked from commit 31ce14a)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears all values which are stored in local storage by the adapter when expired or malformed. This fixes a bug where some items were not removed from storage due to a mismatched index in the loop that removes them.
Closes #15635