Implement pagination for getLDAPRoleMappings #34043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf331f8 to
a276b57
Compare
2 tasks
e38c218 to
5f51299
Compare
Contributor
|
@ahus1 @pedroigor Can any of you please trigger the CI for this one? |
5f51299 to
6f7f8ff
Compare
sguilhen
reviewed
Oct 23, 2024
...ap/src/main/java/org/keycloak/storage/ldap/mappers/membership/UserRolesRetrieveStrategy.java
Outdated
Show resolved
Hide resolved
6f7f8ff to
1b8fbd2
Compare
Contributor
Author
|
@sguilhen think we can also restart a pipeline now. Tested fully it manually for all the build steps so maybe mature enough to attempt a rebuild. |
Contributor
|
@TheOignon You don't have to run all of those manually, that's too much trouble :) @ahus1 @pedroigor Would you mind re-running the CI for this one? |
1b8fbd2 to
92a84b6
Compare
pedroigor
approved these changes
Oct 28, 2024
Contributor
|
@pedroigor failure doesn't seem related - need to re-run the windows dist test |
On Active Directory, allow to retrieve more groups than the MaxPageSize (default to 1000). Without this patch, we need to increase the MaxPageSize which does not really scale. Implemented only for the LoadRolesByMember startegy. Closes keycloak#34042 Signed-off-by: Alexi Vandevoorde <[email protected]>
Signed-off-by: Alexi Vandevoorde <[email protected]>
92a84b6 to
5d85e34
Compare
pedroigor
pushed a commit
to pedroigor/keycloak
that referenced
this pull request
Oct 28, 2024
* Implement pagination for getLDAPRoleMappings On Active Directory, allow to retrieve more groups than the MaxPageSize (default to 1000). Without this patch, we need to increase the MaxPageSize which does not really scale. Implemented only for the LoadRolesByMember startegy. Closes keycloak#34042 Signed-off-by: Alexi Vandevoorde <[email protected]>
pedroigor
added a commit
that referenced
this pull request
Oct 29, 2024
* Implement pagination for getLDAPRoleMappings On Active Directory, allow to retrieve more groups than the MaxPageSize (default to 1000). Without this patch, we need to increase the MaxPageSize which does not really scale. Implemented only for the LoadRolesByMember startegy. Closes #34042 Signed-off-by: Alexi Vandevoorde <[email protected]> Co-authored-by: Alexi Vandevoorde <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34042
On Active Directory, allow to retrieve more groups than the MaxPageSize (default to 1000). Without this patch, we need to increase the MaxPageSize which does not really scale. Implemented only for the LoadRolesByMember startegy.