Honor baseUrl when generating client home url in admin-ui #34016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
With this change the home url for the security-admin-console client is correctly generated. |
0fad2e4 to
949b59a
Compare
Contributor
|
@thomasdarimont could you also update the tests for this one? |
949b59a to
a0b47d4
Compare
Contributor
Author
|
@jonkoops I added some tests for the generated Home URLs for built-in clients and fixed an existing incorrect test for "test when root url constrains ${authAdminUrl}" |
…4015) Previously, the baseUrl was not considered when ${authAdminUrl} was used in the URLs, e.g. for security-admin-console client. Fixes keycloak#34015 Signed-off-by: Thomas Darimont <[email protected]>
- Fix url parameterization in "test when root url constrains ${authAdminUrl}"
- Add tests for home URL for built-in clients (account-console, security-admin-console)
- Add data-testid attribute to ease finding client home URLs
Signed-off-by: Thomas Darimont <[email protected]>
a0b47d4 to
af43f0b
Compare
jonkoops
approved these changes
Oct 18, 2024
Contributor
jonkoops
left a comment
There was a problem hiding this comment.
Looks great @thomasdarimont, thanks for this!
jonkoops
pushed a commit
to jonkoops/keycloak
that referenced
this pull request
Oct 18, 2024
…ole (keycloak#34016) Closes keycloak#34015 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit c7bcb26)
Contributor
|
Backport for v26 is up under #34087 |
jonkoops
added a commit
that referenced
this pull request
Oct 18, 2024
…ole (#34016) (#34087) Closes #34015 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit c7bcb26) Co-authored-by: Thomas Darimont <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the baseUrl was not considered when ${authAdminUrl} was used in the URLs, e.g. for security-admin-console client.
Fixes #34015