Skip to content

BACKPORT: also call onToggle on open changed (#33813) #34481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agagancarczyk merged 1 commit into from
Oct 30, 2024
Merged

BACKPORT: also call onToggle on open changed (#33813) #34481

agagancarczyk merged 1 commit into from
Oct 30, 2024

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Oct 30, 2024

fixes: #31415
backport: #33813

Signed-off-by: Erik Jan de Wit [email protected]
(cherry picked from commit 624817b)

@edewit
also call onToggle on open changed (keycloak#33813)
f6798de 
fixes: keycloak#31415

Signed-off-by: Erik Jan de Wit <[email protected]>
(cherry picked from commit 624817b)
@edewit edewit requested a review from a team as a code owner October 30, 2024 08:10
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=130.0.6723.58)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test

@edewit edewit self-assigned this Oct 30, 2024
@agagancarczyk agagancarczyk merged commit 6dbe8f7 into keycloak:release/26.0 Oct 30, 2024
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @agagancarczyk