Revise help icons for WebauthnPolicy settings (#34465) #34466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @tnorimat I added missing help label icons of the Webauthn Policy and Webauthn Passwordless Policy settings and revised some help texts. Before: After: |
tnorimat
approved these changes
Oct 29, 2024
Contributor
tnorimat
left a comment
There was a problem hiding this comment.
Thank you for the PR. It looks good to me.
- Add missing icons with help labels - Use correct help text for webAuthnPolicyCreateTimeout Fixes keycloak#34465 Signed-off-by: Thomas Darimont <[email protected]>
27d5f82 to
8b9d7b3
Compare
edewit
approved these changes
Oct 30, 2024
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Nov 6, 2024
…oak#34466) - Add missing icons with help labels - Use correct help text for webAuthnPolicyCreateTimeout Fixes keycloak#34465 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit e41ca1f)
edewit
pushed a commit
to edewit/keycloak
that referenced
this pull request
Nov 11, 2024
…oak#34466) - Add missing icons with help labels - Use correct help text for webAuthnPolicyCreateTimeout Fixes keycloak#34465 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit e41ca1f)
jonkoops
pushed a commit
that referenced
this pull request
Nov 11, 2024
- Add missing icons with help labels - Use correct help text for webAuthnPolicyCreateTimeout Fixes #34465 Signed-off-by: Thomas Darimont <[email protected]> (cherry picked from commit e41ca1f) Co-authored-by: Thomas Darimont <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34465