Skip to content

Improve fa translations #33350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 2 commits into from
Oct 2, 2024
Merged

Improve fa translations #33350

ahus1 merged 2 commits into from
Oct 2, 2024

Conversation

@uchar
Copy link
Contributor

@uchar uchar commented Sep 27, 2024

In persian language . should be at the end of sentence

@uchar uchar requested review from a team as code owners September 27, 2024 13:54
@ahus1 ahus1 self-assigned this Sep 30, 2024
@ahus1
Copy link
Contributor

ahus1 commented Sep 30, 2024

Thank you for the updated translation. For merging it, we need another native speaker to approve it. Maybe you know someone who can review it?

Maybe @sharifrezvani who contributed the original translation can provide a review.

In the meantime, there is no need to rebase this PR or merge the main branch into this one unless there is a conflict.

sharifrezvani
sharifrezvani approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@sharifrezvani sharifrezvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the updated translations look fine to we, it's strange how i missed these in the first place, my bad

@ahus1
Copy link
Contributor

ahus1 commented Oct 2, 2024

Thank you for the review @sharifrezvani!

@ahus1 ahus1 enabled auto-merge (squash) October 2, 2024 14:36
@ahus1 ahus1 merged commit 54b6cd6 into keycloak:main Oct 2, 2024
This was referenced Oct 2, 2024
Closed
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 2, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 2, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#residentKey

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=c4429f4b-cfe3-48e9-bab8-08538829e623&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.UserVerificationRegisterTest#discouragedNoVerification

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=a257efc5-b852-485f-95a7-c52d3ddcba74&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserInvalidEmail

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=cd2e8989-21b3-4997-ab1e-487657ba910b&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@uchar uchar deleted the patch-1 branch October 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@sharifrezvani sharifrezvani sharifrezvani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uchar @ahus1 @sharifrezvani