Skip to content

[quarkus-next] Fix: wrong script location used in the preparation phase #33191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmuzikar merged 1 commit into from
Sep 27, 2024
Merged

[quarkus-next] Fix: wrong script location used in the preparation phase #33191

vmuzikar merged 1 commit into from
Sep 27, 2024

Conversation

@Pepo48
Copy link
Contributor

@Pepo48 Pepo48 commented Sep 23, 2024

No description provided.

@Pepo48 Pepo48 requested a review from a team as a code owner September 23, 2024 09:27
@Pepo48 Pepo48 requested a review from vmuzikar September 23, 2024 09:28
This was referenced Sep 23, 2024
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 23, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Sep 23, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

@vmuzikar vmuzikar merged commit 97c032d into keycloak:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pepo48 @jonkoops @vmuzikar