Skip to content

Add check to ensure that no unstaged proto.lock files exist on PRs is… #33952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhajas merged 1 commit into from
Oct 15, 2024
Merged

Add check to ensure that no unstaged proto.lock files exist on PRs is… #33952

mhajas merged 1 commit into from
Oct 15, 2024

Conversation

@ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented Oct 15, 2024

Closes #33566

@ryanemerson
Add check to ensure that no unstaged proto.lock files exist on PRs is…
a48a72d 
…sued against release/26.x branches (keycloak#33592)

Closes keycloak#33566

Signed-off-by: Ryan Emerson <[email protected]>
@ryanemerson ryanemerson requested a review from a team as a code owner October 15, 2024 12:21
mhajas
mhajas approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport

@mhajas mhajas self-assigned this Oct 15, 2024
@mhajas mhajas enabled auto-merge (squash) October 15, 2024 12:22
@mhajas mhajas merged commit fc09a27 into keycloak:release/26.0 Oct 15, 2024
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 15, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 15, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=129.0.6668.89)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mhajas mhajas mhajas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mhajas mhajas

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanemerson @mhajas