Allow Keycloak JS to be initialized without passing options #33950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#8935 Signed-off-by: Jon Koops <[email protected]>
Contributor
Author
|
I recommended reviewing this PR with white-space hidden, as otherwise the diff can be a bit overwhelming. Not much logic has changed, but some indentation has. |
ssilvert
approved these changes
Oct 15, 2024
jonkoops
added a commit
to jonkoops/keycloak
that referenced
this pull request
Oct 15, 2024
…#33950) Closes keycloak#8935 Signed-off-by: Jon Koops <[email protected]> (cherry picked from commit 228c21a)
jonkoops
added a commit
that referenced
this pull request
Oct 15, 2024
…33962) Closes #8935 Signed-off-by: Jon Koops <[email protected]> (cherry picked from commit 228c21a)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
init()method to be called without providing any options, defaulting to an empty object instead. This allows the removal of some conditional code and aligns it with the documentation, which omits the options in several instances.Closes #8935