Check if deviceRepresentation is set
#33828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartinc
approved these changes
Oct 11, 2024
Contributor
rmartinc
left a comment
There was a problem hiding this comment.
Weird issues in CI, but they seem to be unrelated. Changes LGTM!
Contributor
Author
|
Failures might be resolved by #33829 |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButtonKeycloak CI - Forms IT (chrome) |
a24b066 to
8452019
Compare
Closes keycloak#33814 Signed-off-by: Jon Koops <[email protected]> (cherry picked from commit 008faf4)
8452019 to
718fcdc
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButtonKeycloak CI - Forms IT (chrome) |
stianst
approved these changes
Oct 15, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33814
Signed-off-by: Jon Koops [email protected]
(cherry picked from commit 008faf4)