Skip to content

Removed hard-coded LTR dir attribute in inputs in configure OTP template #33754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Oct 9, 2024
Merged

Removed hard-coded LTR dir attribute in inputs in configure OTP template #33754

ahus1 merged 1 commit into from
Oct 9, 2024

Conversation

@jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Oct 9, 2024

This should be done in the html opening tag only (see issue #33642)

Closes #32844

Signed-off-by: Jon Haynes [email protected]
(cherry picked from commit df30358)

@jonkoops
Removed hard-coded LTR dir attribute in inputs in configure OTP template
35d1879 
This should be done in the html opening tag only (see issue keycloak#33642)

Closes keycloak#32844

Signed-off-by: Jon Haynes <[email protected]>
(cherry picked from commit df30358)
@jonkoops jonkoops requested review from a team as code owners October 9, 2024 15:41
@jonkoops jonkoops enabled auto-merge (squash) October 9, 2024 15:41
@jonkoops jonkoops mentioned this pull request Oct 9, 2024
Merged
@ahus1 ahus1 disabled auto-merge October 9, 2024 15:42
@ahus1 ahus1 enabled auto-merge (squash) October 9, 2024 15:42
@ahus1 ahus1 self-assigned this Oct 9, 2024
@ahus1 ahus1 merged commit 207e6db into keycloak:release/26.0 Oct 9, 2024
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 9, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 9, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=129.0.6668.89)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

@jonkoops jonkoops deleted the backport-33652-26.0 branch October 10, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonkoops @ahus1