Skip to content

Ensure createRegisterUrl() calls are awaited internally #33650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkoops merged 1 commit into from
Oct 7, 2024
Merged

Ensure createRegisterUrl() calls are awaited internally #33650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions js/libs/keycloak-js/lib/keycloak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,8 +1329,8 @@ function Keycloak (config) {
throw new Error("Logout failed, request returned an error code.");
},

register: function(options) {
window.location.assign(kc.createRegisterUrl(options));
register: async function(options) {
window.location.assign(await kc.createRegisterUrl(options));
return createPromise().promise;
},

Expand Down Expand Up @@ -1486,9 +1486,9 @@ function Keycloak (config) {
return promise.promise;
},

register : function(options) {
register : async function(options) {
var promise = createPromise();
var registerUrl = kc.createRegisterUrl();
var registerUrl = await kc.createRegisterUrl();
var cordovaOptions = createCordovaOptions(options);
var ref = cordovaOpenWindowWrapper(registerUrl, '_blank', cordovaOptions);
ref.addEventListener('loadstart', function(event) {
Expand Down Expand Up @@ -1555,9 +1555,9 @@ function Keycloak (config) {
return promise.promise;
},

register : function(options) {
register : async function(options) {
var promise = createPromise();
var registerUrl = kc.createRegisterUrl(options);
var registerUrl = await kc.createRegisterUrl(options);
universalLinks.subscribe('keycloak' , function(event) {
universalLinks.unsubscribe('keycloak');
window.cordova.plugins.browsertab.close();
Expand Down