Skip to content

BACKPORT: reset error so when doing a new request, error could be gone (#32974) #33591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agagancarczyk merged 2 commits into from
Oct 8, 2024
Merged

BACKPORT: reset error so when doing a new request, error could be gone (#32974) #33591

agagancarczyk merged 2 commits into from
Oct 8, 2024

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Oct 4, 2024

fixes: #32847
backport: #32974

Signed-off-by: Erik Jan de Wit [email protected]
(cherry picked from commit 57dc5a1)

@edewit edewit requested a review from a team as a code owner October 4, 2024 12:54
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Oct 4, 2024
Closed
agagancarczyk
agagancarczyk approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@agagancarczyk agagancarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agagancarczyk agagancarczyk enabled auto-merge (squash) October 8, 2024 12:36
@agagancarczyk agagancarczyk merged commit 5c5c999 into keycloak:release/26.0 Oct 8, 2024
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 8, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 8, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agagancarczyk agagancarczyk

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @agagancarczyk