added organizations table to account #32311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Jan de Wit <[email protected]>
Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Erik Jan de Wit <[email protected]>
pedroigor
previously approved these changes
Aug 22, 2024
Signed-off-by: Erik Jan de Wit <[email protected]>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.organization.authentication.OrganizationBruteForceTest#testRaceAttackPermanentLockout |
pedroigor
approved these changes
Aug 22, 2024
ssilvert
approved these changes
Aug 22, 2024
|
|
||
| import java.util.Set; | ||
|
|
||
| public class OrganizationRepresentation { |
Contributor
There was a problem hiding this comment.
We already have a version of OrganizationRepresentation.java in ../idm directory. It would be cleaner to synthesize the two using some form of polymorphism like using a base class and/or interfaces.
I see that ClientRepresentation.java has the same issue. So I'm fine if we want to refactor both in a later PR.
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Aug 30, 2024
* added organizations table to account Signed-off-by: Erik Jan de Wit <[email protected]> Signed-off-by: Pedro Igor <[email protected]> Co-authored-by: Pedro Igor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Erik Jan de Wit [email protected]