Drop redundant index on client sessions #32665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#32583 Signed-off-by: Alexander Schwartz <[email protected]>
Contributor
Author
|
@mhajas - please review when you have the time. Thanks! |
Contributor
|
This migration fails and therefore prohibits the Keycloak startup when the index is not existing in the first place. It should be checked and MARK_RAN like here: jpa-changelog-24.0.2.xml. I will create an issue for it and try to make a corresponding PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested using example data and explain plains that the index is not used on MariaDB, PostgreSQL and OracleDB. Also got confirmation from @sschu that MSSQL will not need it.
Closes #32583