Skip to content

Conversation

@pruivo
Copy link
Member

@pruivo pruivo commented Jul 12, 2024

A bug in Infinispan prevents the metrics to be registered if the "stack" is not specified.
Change the default configuration shipped with Keycloak to use the UDP stack as default.
UDP is the default in previous Keycloak versions.

Fixes #31218

A bug in Infinispan prevents the metrics to be registered if the "stack"
is not specified.
Change the default configuration shipped with Keycloak to use the UDP
stack as default.
UDP is the default in previous Keycloak versions.

Fixes keycloak#31218

Signed-off-by: Pedro Ruivo <[email protected]>
@pruivo pruivo marked this pull request as ready for review July 12, 2024 10:49
@pruivo pruivo requested review from a team as code owners July 12, 2024 10:49
@pruivo pruivo requested a review from ahus1 July 12, 2024 10:49
closes: keycloak#31218

Signed-off-by: Alexander Schwartz <[email protected]>
@ahus1
Copy link
Contributor

ahus1 commented Jul 16, 2024

@pruivo - I removed the paragraph about JDK21 virtual threads for the following reasons:

  • AFAIK the latest RHDG release hasn't tested virtual threads, and https://issues.redhat.com/browse/ISPN-16105 is still open. I'd like to understand more about the missing pieces for this task.
  • If we would choose to support JDK virtual threads for JGroups for Keycloak's embedded Infinispan despite the issue mentioned above is open, we should test this first. If we then think it is an improvement, it should be enabled automatically if we detect JDK21 without the need for the user to read the docs and to configure it manually.

To pursue this further, please bring it to our team discussions and/or create an issue for this breaking down the activities needed for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify if JGroups thread metrics can be shown with embedded Infinispan

2 participants