Update caching docs to match breaking changes in v25 #31047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for this change to the docs, which is correct. To be able to merge your contribution, your commit needs to be signed off as outlined in the to your commit. Thanks! |
Contributor
Author
|
Sorry about that 😅 Done now 🙌 |
In the latest Keycloak version (v25.0.1) the cache options are not build options anymore. They now have to be provided during runtime. Signed-off-by: Diego Garcia Lozano <[email protected]>
Contributor
|
@dglozano - out of curiosity: Did you make this change using the GitHub web UI? I found a link how we as a project can enforce the sign-off to be present automatically. I hope to update it later this month. |
Contributor
Author
|
@ahus1 Yes I did it using the Github web UI 😄 To fix it I amended the commit locally and forced push |
Contributor
Thank you for confirming my suspicion here. I hope to have everything in place for users of the GitHub web UI later this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Keycloak version (v25.0.1) the cache options are not build options anymore. They now have to be provided during runtime.
Closes #31050