Parse saml urls correctly if the bindings are different #31805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The failed test is because of #31828. It seems to be a known bug. I can rebase the PR when fixed. |
Closes keycloak#31780 Signed-off-by: rmartinc <[email protected]>
Contributor
Author
|
Rebased now the issue seems to be fixed. |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackPermanentLockoutKeycloak CI - Forms IT (firefox) |
mposolda
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31780
The singleLogoutServiceUrl was parsed related to the singleSignOnServiceUrl. The logout url was forced to use the same binding than the singon url (don't know why, maybe some historic reason, previous configuration options or similar). The PR just modifies the parsing to make singleLogoutServiceUrl/postBindingLogout independent of singleSignOnServiceUrl/postBindingResponse. Now they can use different bindings. As usual POST is preferred in both if available. Test added.