Skip to content

Conversation

@daviddelannoy
Copy link
Contributor

Closes #30368

@daviddelannoy
Copy link
Contributor Author

Hi @ahus1
I think that a s is missing in the documentation for the new feature persistent-user-sessions

@ahus1 ahus1 enabled auto-merge (rebase) June 12, 2024 09:16
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, it slipped everyone else's review!

Could you please create the same PR also against the release branch for 25? Thanks!

@ahus1 ahus1 disabled auto-merge June 12, 2024 09:17
@ahus1 ahus1 enabled auto-merge (squash) June 12, 2024 09:18
@daviddelannoy
Copy link
Contributor Author

Thank you for fixing this, it slipped everyone else's review!

Could you please create the same PR also against the release branch for 25? Thanks!

no worries, with the starting check in the feature flag list it's easy to get the good value :)
I am creating the PR against the release branch yes

@ahus1 ahus1 self-assigned this Jun 12, 2024
@ahus1 ahus1 merged commit d4fc524 into keycloak:main Jun 12, 2024
@daviddelannoy
Copy link
Contributor Author

@ahus1

I think that I committed too quickly ^^

I could have fixed another typo I guess, please confirm that this sentence here, I'll submit a small PR later : https://github.com/keycloak/keycloak/blob/main/docs/documentation/upgrading/topics/changes/changes-25_0_0.adoc?plain=1#L145

should be

The data will be stored in the tables offline_user_session and offline_client_session with offline_flag set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation : label error for persistent-user-sessions feature flag

2 participants