Migration of sessions in KC25 should run only on migration, not on imports #30352
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ports Closes keycloak#30351 Signed-off-by: Alexander Schwartz <[email protected]>
c0d954a to
1fcafb3
Compare
Contributor
Author
|
@mhajas - The tests are green, and I tested locally that the migration is called upon migration when a new version of Keycloak starts up. Please give it a review when you have the time. I plan to do a backport to KC25 once this is merged. Thanks! |
mhajas
approved these changes
Jun 12, 2024
Contributor
mhajas
left a comment
There was a problem hiding this comment.
Thank you for the fix. It makes sense to me, however, I am not sure it makes sense to merge this fix to main, since this code will be removed in 26. We can send the PR only to 25. But still I am approving and leave it to you whether we want to merge or no.
Contributor
Author
|
I'm so used to first do things in upstream, and then backport them, let's stick to that. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30351