adds rtl for admin ui #30965
adds rtl for admin ui #30965
Conversation
part of: keycloak#29974 Signed-off-by: Erik Jan de Wit <[email protected]>
| } | ||
| }); | ||
| if (RTL_LOCALES.includes(this.#me.locale)) { | ||
| document.getElementsByTagName("html")[0].setAttribute("dir", "rtl"); |
There was a problem hiding this comment.
I believe the preferred locale is already known when index.ftl is rendered, so you could also handle this at the template level.
There was a problem hiding this comment.
That's not true atm, we could introduce it in the template though, but why would that be better?
There was a problem hiding this comment.
Ah, you are right, we only have this for the account console, but not the admin console. The benefit would be that it would be present on initial render, so the browser knows everything about the locale right away.
There was a problem hiding this comment.
right, but it's almost instant as this will get triggered once the user is logged in
jonkoops
left a comment
There was a problem hiding this comment.
LGTM, let's work on handling this consistently in all themes as a follow up.
part of: keycloak#29974 Signed-off-by: Erik Jan de Wit <[email protected]>
part of: #29974
Signed-off-by: Erik Jan de Wit [email protected]