Skip to content

Upgrade to Quarkus 3.8.4 #28885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmuzikar merged 3 commits into from
May 2, 2024
Merged

Upgrade to Quarkus 3.8.4 #28885

vmuzikar merged 3 commits into from
May 2, 2024

Conversation

@vmuzikar
Copy link
Contributor

@vmuzikar vmuzikar commented Apr 18, 2024 •
edited
Loading

Closes #28880

This includes also a backport of #28857 and #29030 that's required for Quarkus 3.8.4. (CC @Pepo48)

On hold until RHBQ 3.8.4 is available.

@vmuzikar vmuzikar added the status/hold PR should not be merged. On hold for later. label Apr 18, 2024
@vmuzikar vmuzikar force-pushed the quarkus-384-kc24 branch 2 times, most recently from f75354b to ddadedd Compare April 19, 2024 07:38
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 19, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Apr 19, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.SessionTest#welcomeScreenSsoTimeoutTest

Keycloak CI - Account Console IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"#username"}
  (Session info: chrome-headless-shell=123.0.6312.122)
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordLink

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az914-209', ip: '10.1.0.26', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1018-azure', java.version: '17.0.10'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

Pepo48
Pepo48 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Pepo48 Pepo48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmuzikar LGTM. Thank you!

@vmuzikar vmuzikar removed the status/hold PR should not be merged. On hold for later. label Apr 30, 2024
Pepo48 and others added 2 commits April 30, 2024 17:50
@Pepo48 @vmuzikar
quarkus-next: java.util.NoSuchElementException: No value present caus…
83dd82b 
…es quarkus-server build failure (keycloak#28857)

* resolveFileLogLocation transformer method now checks the location value presence

Closes: keycloak#28856

Signed-off-by: Peter Zaoral <[email protected]>
(cherry picked from commit f9e68cd)
@vmuzikar
Upgrade to Quarkus 3.8.4
1bfdf54 
Closes keycloak#28880

Signed-off-by: Václav Muzikář <[email protected]>
@Pepo48 @vmuzikar
Make PropertyMapper to use Keycloak options' default values (keycloak…
7aef8bb 
…#29030)

* improved a condition in PropertyMapper.java

Related to: keycloak#28856

Signed-off-by: Peter Zaoral <[email protected]>
(cherry picked from commit 86b2803)
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Apr 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Apr 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oauth.RefreshTokenTest#refreshTokenWithDifferentIssuer

Keycloak CI - Base IT (6)

java.lang.RuntimeException: java.lang.RuntimeException: java.net.UnknownHostException: proxy.kc.127.0.0.1.nip.io: Temporary failure in name resolution
	at org.keycloak.testsuite.arquillian.undertow.lb.SimpleUndertowLoadBalancer.start(SimpleUndertowLoadBalancer.java:121)
	at org.keycloak.testsuite.oauth.RefreshTokenTest.refreshTokenWithDifferentIssuer(RefreshTokenTest.java:313)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
...

java.lang.RuntimeException: java.lang.RuntimeException: java.net.UnknownHostException: proxy.kc.127.0.0.1.nip.io
	at org.keycloak.testsuite.arquillian.undertow.lb.SimpleUndertowLoadBalancer.start(SimpleUndertowLoadBalancer.java:121)
	at org.keycloak.testsuite.oauth.RefreshTokenTest.refreshTokenWithDifferentIssuer(RefreshTokenTest.java:313)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
...

Report flaky test

@vmuzikar vmuzikar marked this pull request as ready for review May 2, 2024 07:18
@vmuzikar vmuzikar requested review from a team as code owners May 2, 2024 07:18
@vmuzikar
Copy link
Contributor Author

vmuzikar commented May 2, 2024

This should be now ready, no need to hold it for RHBQ any longer.

@vmuzikar vmuzikar requested a review from Pepo48 May 2, 2024 07:19
@vmuzikar vmuzikar merged commit 3f2951d into keycloak:release/24.0 May 2, 2024
@vmuzikar vmuzikar deleted the quarkus-384-kc24 branch May 2, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

@Pepo48 Pepo48 Pepo48 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmuzikar @ahus1 @Pepo48