Skip to content

Conversation

@shawkins
Copy link
Contributor

closes #26075

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thanks for the PR. I'm probably doing something wrong but I'm unable to reproduce the original issue.

Tried something as simple as:

kc.sh build --db postgres

with a fresh dist (no previous starts or augmentation) and I don't see the Next time you run the server, just run... message. Haven't investigate further though...

@shawkins
Copy link
Contributor Author

@vmuzikar sorry the reproduction is incomplete. It's the inclusion of pre-command arguments that's causing this, because it confuses the checks being performed in kc.sh.

./kc.sh --verbose build --db postgres

Will tell you to run:

kc.sh build --optimized

  • without the verbose as well

./kc.sh --config-file foo build

Will tell you to run:

kc.sh build --optimized --config-file=foo

With the config-file argument in the wrong place.

Unfortunately the verbose and config-file handling happen with start as well - that will need another issue to fix.

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thanks for clarifying. I was able to reproduce and the fix works correctly.

@vmuzikar vmuzikar merged commit 93e9078 into keycloak:main Jan 23, 2024
@cypress
Copy link

cypress bot commented Jan 24, 2024

Passing run #10744 ↗︎

0 1106 108 0 Flakiness 0

Details:

fix: auto-build not needed for build (#26099)
Project: Keycloak Admin UI Commit: 93e90789fe
Status: Passed Duration: 08:11 💡
Started: Jan 24, 2024 12:27 AM Ended: Jan 24, 2024 12:35 AM

Review all test suite changes for PR #26099 ↗︎

ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next time you start message references the wrong command

2 participants