Removal EPL-licensed org.eclipse.sisu.inject dependency for CNCF compliance #24686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
Closed
shawkins
approved these changes
Nov 10, 2023
Contributor
shawkins
left a comment
There was a problem hiding this comment.
LGTM, I'm not aware of any need for this jar, and a clean test run should be sufficient to confirm.
Contributor
Author
|
The tests failures seem unrelated to the changes proposed here, anyway it will be required to dig more into it next week. |
mabartos
approved these changes
Nov 13, 2023
Contributor
mabartos
left a comment
There was a problem hiding this comment.
Yes, this dependency is not used in runtime, and if the reaugmentation works as expected (jobs are green, so it confirms it), I'm ok with this change.
Out of the scope: We could also suggest removing the deployment JARs for the optimized images[1] as they do not allow reaugmentation anyway.
[1] https://quarkus.io/guides/reaugmentation#3-optional-delete-the-deployments-folder
…liance Closes keycloak#24685 Signed-off-by: Bruno Oliveira da Silva <[email protected]>
d3d0aed to
4e7f63b
Compare
vmuzikar
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we go ahead with the merge, I want to get the approval from the @keycloak/cloud-native team to ensure that this change won't break anything. I've already tried it out, which you can see here: keycloak-poc/keycloak#1. It seems that all the checks are passing in the pipeline.
After talking with the Quarkus team, they mentioned that this dependency isn't required in the runtime. It's specifically used for the bootstrapping part and the Maven resolver. And that's part of 'lib/deployment' folder of the Keycloak mutable-jar distribution.
If the team realizes that's not possible to remove we can close the proposed change here.
Closes #24685