Quarkus IT that use Oracle DB don't work with -Dproduct #23084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahus1
approved these changes
Sep 8, 2023
vmuzikar
approved these changes
Sep 8, 2023
Contributor
vmuzikar
left a comment
There was a problem hiding this comment.
Changes LGTM, does what it's supposed to do but I was unable to run the OracleTest in the end. We don't test it in the CI and even when trying to get it working locally I was unable to manually run the DB container as the prerequisite. @mabartos Were you able to run the test?
In any case, this PR correctly addresses the issue and even if the test is broken, it's out of the scope of this PR and we'd address it separately.
1 flaky test on run #8879 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Realm settings client profiles tab tests > Should not create duplicate client profile |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23058
We can improve the process around the JDBC drivers' copies to
providersin a follow-up task.