Skip to content

Return Oracle JDBC driver to the upstream #23006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Sep 6, 2023
Merged

Return Oracle JDBC driver to the upstream #23006

ahus1 merged 1 commit into from
Sep 6, 2023

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Sep 6, 2023 •
edited
Loading

Closes #22999

I've been following #22577 and #22598.

Tested built Keycloak distro in community/product mode and also the auth-server-quarkus. Everything should be working as expected.

@vmuzikar @ahus1 Could you please check it?

@mabartos mabartos requested review from a team as code owners September 6, 2023 09:51
@mabartos mabartos requested a review from a team September 6, 2023 09:51
vmuzikar
vmuzikar previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

ahus1
ahus1 previously approved these changes Sep 6, 2023
View reviewed changes
@ahus1 ahus1 enabled auto-merge (rebase) September 6, 2023 09:58
@ghost ghost added the flaky-test label Sep 6, 2023
@ghost ghost mentioned this pull request Sep 6, 2023
Closed
auto-merge was automatically disabled September 6, 2023 11:38

Head branch was pushed to by a user without write access

@mabartos mabartos dismissed stale reviews from ahus1 and vmuzikar via 9d6bb49 September 6, 2023 11:38
@mabartos
Copy link
Contributor Author

mabartos commented Sep 6, 2023

@vmuzikar @ahus1 Sorry, forgot to include changes for the present test (#22934).

@ahus1 ahus1 enabled auto-merge (rebase) September 6, 2023 11:52
@ahus1 ahus1 mentioned this pull request Sep 6, 2023
Merged
@mabartos
Copy link
Contributor Author

mabartos commented Sep 6, 2023

Something bad happened to GHA CI.

@ahus1 @vmuzikar Could you rerun it, please?

@ahus1
Copy link
Contributor

ahus1 commented Sep 6, 2023

@mabartos - ok, did a re-run of all jobs. Let's wait a moment. If it doesn't help, please rebase and force-push.

@ghost ghost mentioned this pull request Sep 6, 2023
Closed
@ghost
Copy link

ghost commented Sep 6, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.WelcomeScreenTest#personalInfoTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/personal-info within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

ghost
ghost reviewed Sep 6, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost ghost mentioned this pull request Sep 6, 2023
Closed
This was referenced Sep 6, 2023
Closed
Closed
@ahus1 ahus1 merged commit 6ca78b7 into keycloak:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return Oracle driver

3 participants

@mabartos @ahus1 @vmuzikar