Skip to content

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Jul 27, 2023

Closes #22019

@stianst stianst requested a review from a team as a code owner July 27, 2023 06:45
@stianst stianst force-pushed the conditional-refactor branch 2 times, most recently from d9436d3 to db1cf48 Compare July 27, 2023 07:15
@stianst stianst force-pushed the conditional-refactor branch from db1cf48 to b8476dc Compare July 27, 2023 07:16
@cypress
Copy link

cypress bot commented Jul 27, 2023

1 flaky tests on run #8270 ↗︎

0 527 48 0 Flakiness 1

Details:

Merge b8476dc into 5bd4d82...
Project: Keycloak Admin UI Commit: f55ad4b7d3 ℹ️
Status: Passed Duration: 15:04 💡
Started: Jul 27, 2023 7:25 AM Ended: Jul 27, 2023 7:40 AM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stianst stianst merged commit 5bb9da3 into keycloak:main Jul 28, 2023
@stianst stianst deleted the conditional-refactor branch July 28, 2023 05:04
stianst added a commit to stianst/keycloak that referenced this pull request Sep 4, 2023
stianst added a commit that referenced this pull request Sep 4, 2023
This was referenced Sep 6, 2023
@stianst stianst mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor conditional in GH workflows

2 participants