render components based on the annotations #21180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky tests on run #8132 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication test > should add a condition |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
jonkoops
previously approved these changes
Jul 4, 2023
9472ccb to
88ed041
Compare
jonkoops
previously approved these changes
Jul 13, 2023
jonkoops
previously approved these changes
Jul 14, 2023
2 tasks
jonkoops
suggested changes
Jul 18, 2023
| Object.entries(annotations || {}).map(([key, value]) => ({ | ||
| key, | ||
| value, | ||
| value: value as Record<string, unknown>, |
Contributor
There was a problem hiding this comment.
Looking at the type, it is the same as the one it is being cast to. So I think we can omit this cast.
Suggested change
| value: value as Record<string, unknown>, | |
| value, |
Contributor
Author
There was a problem hiding this comment.
the build failed when it was omitted
Contributor
There was a problem hiding this comment.
Ahhh, I see. I didn't re-build the admin client, so I never got the new type.
jonkoops
approved these changes
Jul 18, 2023
jonkoops
pushed a commit
to jonkoops/keycloak
that referenced
this pull request
Aug 23, 2023
* render components based on the annotations * merge fix
jonkoops
added a commit
that referenced
this pull request
Aug 23, 2023
Co-authored-by: Erik Jan de Wit <[email protected]>
This was referenced Sep 4, 2023
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment this only addresses the admin UI, but planned is to refactor this into a common components that work as well for the account ui
fixes: #20837