@jaylinski we actually have an issue open to implement this #19965 for all of the UIs, would you be willing to implement that under this PR?

@jonkoops Thanks for referencing the issue! I pushed the changes.

I took a look at the UI tests. Should I write a test for it? Something like this:

@FindBy(xpath = "//html")
private WebElement htmlRoot;

String lang = htmlRoot.getAttribute("lang");
assertThat(lang, "en");

@jaylinski if you are up for writing some tests to verify this code works that would be awesome yeah.

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.infinispan.CacheExpirationTest#testCacheExpiration

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at [email protected]/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at [email protected]/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:521)
	at [email protected]/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:509)
...

Report flaky test

org.keycloak.testsuite.model.infinispan.CacheExpirationTest#testCacheExpiration

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at [email protected]/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at [email protected]/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:521)
	at [email protected]/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:509)
...

Report flaky test

@jaylinski any progress on those tests? :)

@jaylinski any progress on those tests? :)

@jonkoops I added a test for the login-page. Please review.

Note that I only added the lang-attribute to the login- and account-layout, since the other layouts don't always have a internationalizationEnabled- or currentLanguageTag-value.

Very nice, thanks for adding some tests! Would it also be possible to add another test for the Account Console?

Note that I only added the lang-attribute to the login- and account-layout, since the other layouts don't always have a internationalizationEnabled- or currentLanguageTag-value.

I think that is valid yes, we can split these missing ones out into separate issues and resolve them later.

@ssilvert could I ask you to review the Java code as well? It looks good to me, but I prefer to have another expert look 😉