Use entry action icons without any frame #4203
Conversation
|
|
|
Although I agree that the speech bubbles are perhaps a little confusing, I do like the visual grouping they create. In the screenshot you provided, there is no clear distinction between the different icons and it is not obvious what each group does or which icon belongs to a group in the first place (despite the additional whitespace between the groups). The proposed icons also have very different stroke widths, which creates quite an inhomogeneous overall appearance. |
|
I agree. Here's a screenshot of what it looks like with circles instead: |
|
I like the circles, it also ties in the clone entry icon nicely. |
|
I really like the icons in the first screen shot (in the original posting). Then I looked at the icons with the circles and my first thought was, that it is not good if only these icons have circles and the other icons not. And that you have separator lines between the blocks of icons, so you have a visual separation. But then I had a closer look at the icons with the circles and I must say that they fit better in the complete layout (unique thickness of the lines). But I also have a question: |
The separator lines are very thin and hard to see and some themes swallow them completely.
Yes, that was removed, since it's an action that almost nobody needs when they already have a database. |
|
IMO the |
|
I did not read anything in #4066 (comment), I just had a look at the following screen shot posted there: I want to give some general information about the design of icons. Icons must be easily distinguishable, it must be easy to keep them apart from each other. |
|
That picture is of the entry menu where the size of the distinctive features shouldn't be much of an issue since their function name is right next to the icon (they also don't look that small to me). Icons/distinctive feature sizes matter much more in the toolbar where they aren't named and I think the plus and minus sizes would be big enough once the icons are scaled to the other toolbar icon sizes. |
|
I don't prefer the document icons because they are very busy with the horizontal lines. This detracts from the distinguishing characteristic that Olli mentioned. |
|
Those icons were a suggestion, but I think we discarded them pretty quickly for reasons mentioned. |
|
Like phoerious says, this is just a suggestion. Do what you will with it – I'm not one to hold grudges for discarding a PR. |
bbc24a4 to
9c0d2f9
Compare
Added - Custom Light and Dark themes [#4110, #4769, #4791, #4796, #4892, #4915] - Compact mode to use classic Group and Entry line height [#4910] - View menu to quickly switch themes, compact mode, and toggle UI elements [#4910] - Search for groups and scope search to matched groups [#4705] - Save Database Backup feature [#4550] - Sort entries by "natural order" and move lines up/down [#4357] - Option to launch KeePassXC on system startup/login [#4675] - Caps Lock warning on password input fields [#3646] - Add "Size" column to entry view [#4588] - Browser-like tab experience using Ctrl+[Num] (Alt+[Num] on Linux) [#4063, #4305] - Password Generator: Define additional characters to choose from [#3876] - Reports: Database password health check (offline) [#3993] - Reports: HIBP online service to check for breached passwords [#4438] - Auto-Type: DateTime placeholders [#4409] - Browser: Show group name in results sent to browser extension [#4111] - Browser: Ability to define a custom browser location (macOS and Linux only) [#4148] - Browser: Ability to change root group UUID and inline edit connection ID [#4315, #4591] - CLI: `db-info` command [#4231] - CLI: Use wl-clipboard if xclip is not available (Linux) [#4323] - CLI: Incorporate xclip into snap builds [#4697] - SSH Agent: Key file path env substitution, SSH_AUTH_SOCK override, and connection test [#3769, #3801, #4545] - SSH Agent: Context menu actions to add/remove keys [#4290] Changed - Complete replacement of default database icons [#4699] - Complete replacement of application icons [#4066, #4161, #4203, #4411] - Complete rewrite of documentation and manpages using Asciidoctor [#4937] - Complete refactor of config files; separate between local and roaming [#4665] - Complete refactor of browser integration and proxy code [#4680] - Complete refactor of hardware key integration (YubiKey and OnlyKey) [#4584, #4843] - Significantly improve performance when saving and opening databases [#4309, #4833] - Remove read-only detection for database files [#4508] - Overhaul of password fields and password generator [#4367] - Replace instances of "Master Key" with "Database Credentials" [#4929] - Change settings checkboxes to positive phrasing for consistency [#4715] - Improve UX of using entry actions (focus fix) [#3893] - Set expiration time to Now when enabling entry expiration [#4406] - Always show "New Entry" in context menu [#4617] - Issue warning before adding large attachments [#4651] - Improve importing OPVault [#4630] - Improve AutoOpen capability [#3901, #4752] - Check for updates every 7 days even while still running [#4752] - Improve Windows installer UI/UX [#4675] - Improve config file handling of portable distribution [#4131, #4752] - macOS: Hide dock icon when application is hidden to tray [#4782] - Browser: Use unlock dialog to improve UX of opening a locked database [#3698] - Browser: Improve database and entry settings experience [#4392, #4591] - Browser: Improve confirm access dialog [#2143, #4660] - KeeShare: Improve monitoring file changes of shares [#4720] - CLI: Rename `create` command to `db-create` [#4231] - CLI: Cleanup `db-create` options (`--set-key-file` and `--set-password`) [#4313] - CLI: Use stderr for help text and password prompts [#4086, #4623] - FdoSecrets: Display existing secret service process [#4128] Fixed - Fix changing focus around the main window using tab key [#4641] - Fix search field clearing while still using the application [#4368] - Improve search help widget displaying on macOS and Linux [#4236] - Return keyboard focus after editing an entry [#4287] - Reset database path after failed "Save As" [#4526] - Use SHA256 Digest for Windows code signing [#4129] - Improve handling of ccache when building [#4104, #4335] - macOS: Properly re-hide application window after browser integration and Auto-Type usage [#4909] - Auto-Type: Fix crash when performing on new entry [#4132] - Browser: Send legacy HTTP settings to recycle bin [#4589] - Browser: Fix merging browser keys [#4685] - CLI: Fix encoding when exporting database [#3921] - SSH Agent: Improve reliability and underlying code [#3833, #4256, #4549, #4595] - FdoSecrets: Fix crash when editing settings before service is enabled [#4332]
Replace the chat icons with similar icons that does not have any frame at all.
Downloaded from https://materialdesignicons.com/
Signed-off-by: Andreas Lindhé [email protected]
Type of change
Description and Context
I agree with @OLLI-S comment in #4066, that current choice of icons for actions on entries is a bit strange. They are in speech bubbles, indicating some sort of "comment" or "chat" functionality. My suggestion is to simply drop the frame altogether, which makes the icons larger and hopefully clearer.
I'm perfectly happy to scrap this PR if you have better solutions in mind. Just putting this out there, do what you want with it.
Alternatives
entry-deleteicon (theX) perhaps be a minus instead (either minus or minus-circle-outline)? Makes sense as contrast to the+symbol.Screenshots
Checklist:
-DWITH_ASAN=ON. [REQUIRED]