feat: add optional Unix-only BoringSSL symbol prefixing #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't build with clang-12 to libc++ mismatch
jmayclin
reviewed
Dec 18, 2025
| } | ||
|
|
||
| if config.features.prefix_symbols { | ||
| cfg.define("CMAKE_POSITION_INDEPENDENT_CODE", "ON"); |
There was a problem hiding this comment.
Why do prefixed symbols need position independent code? Minimally we should comment explaining why this is needed.
|
|
||
| /// Prefix applied to all BoringSSL symbols so they don't collide with OpenSSL. | ||
| /// | ||
| const SYMBOL_PREFIX: &str = "BSSL"; |
There was a problem hiding this comment.
This is certainly nicer than nothing, but is there any way to apply a dynamic prefix? Ideally we'd just BSSL_{crate_version}.
CARGO_PKG_VERSION — The full version of your package.
I think that might be the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds an optional prefix-symbols feature to boring and boring-sys that prefixes all BoringSSL libssl/libcrypto symbols to avoid collisions with OpenSSL or other BoringSSL variants.
What this does
Adds a prefix-symbols Cargo feature.
Unix-only build logic that:
Why
This enables BoringSSL to safely coexist with OpenSSL build inside the same process - necessary for interoperability testing with s2n-tls