Crystal 0.18.4 #225
Merged
Crystal 0.18.4 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teger This fixes a test case for stepA.
|
Crystal used in CI looks too old (version 0.10.0). Could you tell me how to fix this? Is Version of crystal fixed? |
|
For now the docker images are under my docker hub account so I have to push them. I've rebuilt the image to pull in 0.18.4 and I've pushed it out. I restarted the test and now your changes pass. |
|
@kanaka Thank you 😄 |
micfan
pushed a commit
to micfan/make-a-lisp
that referenced
this pull request
Nov 8, 2018
Crystal 0.18.4
luelista
pushed a commit
to luelista/mal
that referenced
this pull request
Mar 10, 2024
Crystal 0.18.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed Crystal implementation for Crystal 0.18.4.
I found that a test case for
time_msfailed because it requires 64bit integer. So I changed underlying type ofinttoInt64. Now it works.