Skip to content

Conversation

@rithvikvibhu
Copy link
Collaborator

@rithvikvibhu rithvikvibhu commented Jul 9, 2022

records: set state only of record prop has changed

(closes #533)
After react 16 -> 17 update, state was being updated recursively. Now it checks if the record has actually changed.

collapsible: max-height only when overflow scroll

Fixes overlapping records/bids tables in collapsibles on DomainManager and Auction pages.

wallet: ignore old auction bids when calculating stats

Unrevealed bids from previous auctions were being counted as "revealable" when they shouldn't have been. Now we only consider the latest auction.

pkg: bump to v1.0.0

Bump from 1.0.0-rc1 to 1.0.0. And updates lock file.

i18n: update script to list unchanged translations

The check-all-locale script now lists string that may have been missed translating.

@nlydv
Copy link
Contributor

nlydv commented Jul 18, 2022

When running v1.0.0-rc1, I had encountered an issue where the entire app would become completely blank white anytime I tried to click one of the domains under the domain manager view.

Building and running this PR seems to have fixed that 👍🏽

@rithvikvibhu rithvikvibhu merged commit dab053b into kyokan:master Jul 27, 2022
@rithvikvibhu rithvikvibhu deleted the rc1-fixes branch July 27, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank screen when adding records to a domain

2 participants